Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: use node: prefix on node dependencies #59

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

stramel
Copy link
Collaborator

@stramel stramel commented Oct 10, 2022

Updates node dependencies to use the node: prefix.

Benefits:

  • More explicit protocol makes it more readable and also makes it clear that a built-in module is being imported. Since there are a lot of built-in ones, this extra information is useful for beginners or for someone who might not know about one of them.
  • It reduces the risk of a module present in node_modules overriding the newer imports.

Supported in Node.js starting:

  • v16.0.0, v14.18.0 (ESM import and CommonJS require())
  • v14.13.1, v12.20.0 (only ESM import)

Supported in TypeScript by the latest versions of @types/node.

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2022

🦋 Changeset detected

Latest commit: fc1b0ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
astro-icon Patch
www Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
api-astroicon ✅ Ready (Inspect) Visit Preview Oct 20, 2022 at 5:45PM (UTC)
astroicon ✅ Ready (Inspect) Visit Preview Oct 20, 2022 at 5:45PM (UTC)

Copy link
Owner

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@stramel stramel merged commit 1a5ff6b into natemoo-re:main Oct 26, 2022
@stramel stramel deleted the ms/use-prefixed-node-deps branch October 26, 2022 16:16
@github-actions github-actions bot mentioned this pull request Oct 26, 2022
manuelmeister pushed a commit to manuelmeister/astro-iconify that referenced this pull request Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants