Investigate inconsistent hydration results #111
Labels
bug
Something isn't working
Comments
|
I can confirm the mobile issue on iOS. Likely has to do with Safari's lack of support for The other methods are probably a timing issue as you suspect. I'll take a look. |
|
Oh sorry to clarify, the description above was observed on desktop Chrome before I rolled back my lockfile. I meant to say I was only seeing the first behavior on mobile. I’m fairly certain you do check for |
natemoo-re
added a commit
that referenced
this issue
Jan 31, 2021
natemoo-re
added a commit
that referenced
this issue
Jan 31, 2021
natemoo-re
added a commit
that referenced
this issue
Jan 31, 2021
natemoo-re
added a commit
that referenced
this issue
Feb 22, 2021
natemoo-re
added a commit
that referenced
this issue
Feb 24, 2021
natemoo-re
added a commit
that referenced
this issue
Mar 3, 2021
natemoo-re
added a commit
that referenced
this issue
Mar 3, 2021
natemoo-re
added a commit
that referenced
this issue
Mar 19, 2021
natemoo-re
added a commit
that referenced
this issue
Mar 19, 2021
* wip: snowpack@3.0.0 changes * fix: remove custom document logic from dev * wip: remap snowpack@3.0.0 default output directories * fix(#81): remove PostCSS from core dependencies * fix(#81): remove prettier from core dependencies * fix(83): exclude image/font MIME types from transform * fix(dev): implements a few more snowpack@3.0.0 changes * Ensure shared hydration chunks are included in build (#105) Also include updated package-lock.json based on instructions in https://github.com/natemoo-re/microsite/blob/1853843192cb9e0baa8ff93f872cb595a64fbe7f/.github/CONTRIBUTING.md * Ensure head is rendered for SSG It seems the implementation was intended to achieve this sort of isolation the same way `docContext` is used. But the `useRef` version was basically just sending any children in `Head` into the memory hole on build. * Add another page just to validate that each page gets a new head context as expected * chore: changeset * chore: release 1.1.0-next.4 * Fix an issue with binary public file corruption (#110) * Ensure head is rendered for SSG It seems the implementation was intended to achieve this sort of isolation the same way `docContext` is used. But the `useRef` version was basically just sending any children in `Head` into the memory hole on build. * Add another page just to validate that each page gets a new head context as expected * Fix an issue with binary public file corruption The previous behavior was reading binary files as strings, which was corrupting them on output * fix: missed rebase issue * fix: properly resolve example script in CI * fix: remove assumption that code lives in "node_modules" * fix(examples): prefer readFile to fetch * fix: pin preact to 10.5.10 * fix: pin snowpack to 3.0.x * chore: changeset * chore: v1.1.0-next.5 * chore: fixup package-locks * chore: fixup package-lock files * chore: ignore logfiles * Fix requestIdleCallback logic (#112) * fix(#111): hydration failure in safari * chore: update package lock * fix(#111): use requestIdleCallback shim * chore: changeset * fix: update createPersistentFragment for preact@10.5.11+ * chore: changeset * chore: v1.1.0-next.6 * chore: bump package-lock * chore: update example locks * fix(#119): remove `defer` from inline script * Omit base tag by default (#117) * Omit base tag by default * Ensure resources are prefixed with `/` when base tag is omitted * Lol whoops I meant to remove this * fix(#115): do not include vendor chunk in hydrateBindings * chore: publish create-microsite@0.2.0 * chore: add changeset * chore: v1.1.0-next.7 * chore(deps): snowpack@3.0.13 * fix(#125): prefer pinned Skypack URLs * chore: remove debug * chore: changeset * chore: 1.1.0-next.8 * WIP: dev ssr (#113) * fix(dev): implements a few more snowpack@3.0.0 changes * Ensure shared hydration chunks are included in build (#105) Also include updated package-lock.json based on instructions in https://github.com/natemoo-re/microsite/blob/1853843192cb9e0baa8ff93f872cb595a64fbe7f/.github/CONTRIBUTING.md * chore: fixup package-locks * chore: fixup package-lock files * chore: update example locks * WIP: dev ssr * WIP: dev ssr getStaticProps/Paths * feat: add proper error page handling in dev mode * chore(examples): update deps * feat: finalize dev SSR support * chore(examples): add CSS-in-JS examples * chore(examples): update goober example * fix: cleanup deps Co-authored-by: eyelidlessness <eyelidlessness@users.noreply.github.com> * fix(#126): emit shared css modules (#127) * chore: v1.1.0-next.9 * chore: remove package-locks? * fix: shared CSS module logic * chore: 1.1.0-next.10 * feat(hydration): add "fallback" prop to "withHydrate" * fix: global chunk loading * chore(examples): add custom ssr fallback example * chore: v1.1.0-next.11 * Add benchmark action (#129) * feat: add gzip/brotli to benchmark * chore(action): add benchmark test action * chore(action): test benchmark * chore(action): test benchmark * chore(action): update benchmark filter * chore(action): update benchmark scripts * chore: revert lockfile to v1 * chore(action): update benchmark script * chore(action): update benchmark script * chore(action): update benchmark action * chore(action): update benchmark script * chore(action): update benchmark script * chore(action): update benchmark script * chore(action): update benchmark script * chore(action): update benchmark script * chore(action): add context to benchmark message * chore(action): update benchmark to 15 runs * chore(action): require manual trigger for benchmark action * chore(action): fixup benchmark script * chore(action): add commit to benchmark action * chore(action): fix workflow_dispatch * docs: update benchmark * chore: update benchmark table formatting * chore(bench): restructure benchmarks * chore(bench): add counter example * chore(bench): add lighthouse scores to benchmark * chore(bench): run benchmarks * chore(bench): update size label * Fix preact import regex matching other things (#135) * docs: fix wrong variable, update css in js context (#131) * doc: fix wrong variable name * doc: fix file naming, since it doesn't render jsx * doc: adding with-fela and with-goober example * update without .md extension * Update styling.md * Fix preact import regex matching other things Currently preact import regex matches other things (e.g @mdx-js/preact). * Escape forward slashes Co-authored-by: Sigit Prabowo <sgt@prbw.net> Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com> * Fix incorrect field used for aliases from snowpack user config (#136) * docs: fix wrong variable, update css in js context (#131) * doc: fix wrong variable name * doc: fix file naming, since it doesn't render jsx * doc: adding with-fela and with-goober example * update without .md extension * Update styling.md * Fix aliases from userConfig not being loaded Co-authored-by: Sigit Prabowo <sgt@prbw.net> Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com> * Ensure nested imports are hydrated, allow optional display name override for named exports (#140) * final changes for v1.1.0 Co-authored-by: eyelidlessness <eyelidlessness@users.noreply.github.com> Co-authored-by: eyelidlessness <gnosis@gmail.com> Co-authored-by: Reeto Chatterjee <github@ree.to> Co-authored-by: Sigit Prabowo <sgt@prbw.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
hydrating on idle consistently caused the component to mount as expected and then immediately unmount (which I see at least on mobile for either hydration case on your example)
hydrating on visible caused hydration to sometimes not occur at all/immediately unmount, sometimes occur adjacent to the server rendered node, and sometimes function normally
I strongly suspect there’s some timing factor involved here. But I was in build mode so I didn’t get hung up on it once I brute forced a fix
Originally posted by @eyelidlessness in #107 (comment)
The text was updated successfully, but these errors were encountered: