Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue "'Started-word' event does not work correctly #78" in sapi5 driver for win. #186

Closed
wants to merge 2 commits into from

Conversation

dr0id
Copy link

@dr0id dr0id commented Mar 24, 2021

No description provided.

@dr0id
Copy link
Author

dr0id commented Mar 24, 2021

`starting fox
word fox 1 0
word fox 0 3
word fox 4 5
word fox 10 5
word fox 16 3
word fox 20 6
word fox 27 4
word fox 32 3
word fox 36 4
word fox 41 3
finishing fox True
starting dog
word dog 1 82240
word dog 0 4
word dog 5 1
word dog 7 4
word dog 12 3
finishing dog True

Process finished with exit code 0
`

for sapi5 driver the first word is actually the stream_number and stream_position (e.g. word dog 1 82240 => stream_number=1 and stream_position=82240 )
After that the number are the character position and length of the word (e.g. word dog 0 4 => pos=0 and length=4)

self._driver._proxy.notify(
'started-word', location=char, length=length)
'started-word', location=stream_number, length=stream_position)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably be 'started-utterance' not 'started-word'. Location and length no longer make sense for StartStream.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are probably right. It has been a while since I look at the code.

@willwade
Copy link
Collaborator

See PR #329 - this fixes this now and the None issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants