New Operation Example #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define and implement the limit_order_update_operation. Still needs testing.
Some major facepalms in here... haha! but overall, it's looking good.
Add logic to match an updated limit order if the price is changed to be higher than the previous top-of-book price. I believe this completes bitshares#1604
Add dust check to limit order update logic, and test
Updating an order's expiration must make it expire later than before, not the same or sooner.
I pulled this out of a2192ec because I needed it separated from the rest of that commit.
Guard against the comittee setting fees for the operation which is not yet defined.
nathanielhourt
pushed a commit
that referenced
this pull request
Apr 9, 2019
add unit tests for get_signed_transaction_signers, get_key_references
nathanielhourt
force-pushed
the
issue-1604
branch
from
baa491d
to
55dc688
Compare
|
Hi Nathan, JFYI, I'm going to continue to work on this at bitshares#2743. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exists to provide a permanent home for a mostly clutter-free example of creating a simple new operation and evaluator in BitShares, namely the
limit_order_update_operation. Please note that the changes in 8a82d92 are present as a necessary, but ancillary modification and are not typical of creating a new operation or evaluator.