Rename link 'template' data attribute #83
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a fix for issue #80.
Link's
template
data attribute is already used by Twitter Bootstrap's tooltip JS, producing strange behavior when using both BS Tooltip and Cocoon on the same link.This fix renames
template
toassociation-insertion-template
to limit collision risk.Since this attribute is generated by the gem itself, there should not be any regression, except if some user does JS customization of
template
, which is contradictory with the purpose of the gem.Specs are updated with the new attribute name (I had to change data attributes order since Rails seems to sort them). All 30 specs successful.
I did not update the readme since there was no mention of
template
but maybe you will want to add a note about the change.Thanks !