-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: session - Preloading page cannot redirect to a state that is part of a lazy loaded module #810
Labels
Milestone
Comments
christophercr
referenced
this issue
in christophercr/stark
Oct 31, 2018
… lazy loaded modules. Adapt Showcase to make DemoModule and NewsModule lazy loaded ISSUES CLOSED: #810
christophercr
referenced
this issue
in christophercr/stark
Oct 31, 2018
…om lazy loaded modules. Adapt Showcase to make DemoModule and NewsModule lazy loaded ISSUES CLOSED: #810
christophercr
changed the title
ui: session pages - Preloading page cannot redirect to a state that is part of a lazy loaded module
ui: session - Preloading page cannot redirect to a state that is part of a lazy loaded module
Oct 31, 2018
christophercr
referenced
this issue
in christophercr/stark
Oct 31, 2018
…om lazy loaded modules. Adapt Showcase to make DemoModule and NewsModule lazy loaded ISSUES CLOSED: #810
christophercr
referenced
this issue
in christophercr/stark
Oct 31, 2018
…om lazy loaded modules. Adapt Showcase to make DemoModule and NewsModule lazy loaded ISSUES CLOSED: #810
christophercr
referenced
this issue
in christophercr/stark
Nov 2, 2018
…om lazy loaded modules. Adapt Showcase to make DemoModule and NewsModule lazy loaded ISSUES CLOSED: #810
christophercr
referenced
this issue
in christophercr/stark
Nov 2, 2018
…om lazy loaded modules. Adapt Showcase to make DemoModule and NewsModule lazy loaded ISSUES CLOSED: #810
Closed by #814 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm submitting a...
Current behavior
When trying to navigate to a specific page by typing the URL in the navigation bar of the browser, the app
PreloadingPage
tries to find the corresponding Router state. In case the URL matches an state that only defines a lazy loaded module, thePreloadingPage
navigates to that state which is in fact wrong because it is only a "placeholder" state for the "future" states that will be loaded lazily.Expected behavior
The Preloading page should redirect to the correct final state regardless of whether that state is part of a lazy loaded module or not. This means that in case the state is part of a lazy loaded state, then that module should be loaded first before doing the redirection.
Minimal reproduction of the problem with instructions
PreloadingPage
and then it redirects to the "otherwise" state since it tried to redirect to the wrong state (a placeholder for "future" states of the lazy loaded module without even loading such module).What is the motivation / use case for changing the behavior?
Seamless integration with lazy loaded modules.
Environment
The text was updated successfully, but these errors were encountered: