Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] Support a path as argument to --signal #838

Merged
merged 1 commit into from
Dec 5, 2018
Merged

[ADDED] Support a path as argument to --signal #838

merged 1 commit into from
Dec 5, 2018

Conversation

pires
Copy link
Contributor

@pires pires commented Dec 5, 2018

  • Link to issue, e.g. Resolves #NNN
  • Documentation added (if applicable)
  • Tests added agreed w/ @kozlovic test is not mandatory for this one.
  • Branch rebased on top of current master (git pull --rebase origin master)
  • Changes squashed to a single commit (described here)
  • Build is green in Travis CI
  • You have certified that the contribution is your original work and that you license the work to the project under the Apache 2 license

Resolves #

Changes proposed in this pull request:

  • Make the -sl / --signal flag accept the path to a PID file as an argument. This is useful in scenarios where pgrep isn't available (such as in the official Docker images) but there is a PID file.

/cc @nats-io/core

Signed-off-by: Paulo Pires <pjpires@gmail.com>
@kozlovic kozlovic self-requested a review December 5, 2018 16:51
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution

@kozlovic kozlovic changed the title Support a path as argument to --signal [ADDED] Support a path as argument to --signal Dec 5, 2018
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 5d86964 into nats-io:master Dec 5, 2018
@pires pires deleted the pires/ldm_pidfile branch December 5, 2018 17:08
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 91.627% when pulling 67412b7 on pires:pires/ldm_pidfile into afc3a45 on nats-io:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants