Skip to content

CNCF Updates #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 21, 2018
Merged

CNCF Updates #154

merged 2 commits into from
Mar 21, 2018

Conversation

ColinSullivan1
Copy link
Member

  • Apache 2.0 License
  • Add code of conduct
  • Add owners file
  • Update copyright

@ColinSullivan1
CNCF Updates
18fd868 
* Apache 2.0 License
* Add code of conduct
* Add owners file
* Update copyright
@ColinSullivan1 ColinSullivan1 requested a review from aricart March 20, 2018 22:40
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.72% when pulling 18fd868 on cncf into 28ae1cc on master.

@coveralls
Copy link

coveralls commented Mar 20, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 93.72% when pulling 4861eb0 on cncf into 28ae1cc on master.

aricart
aricart reviewed Mar 20, 2018
View reviewed changes
LICENSE
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright [yyyy] [name of copyright owner]
Copy link
Member

@aricart aricart Mar 20, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update this with "2015-2018 The NATS Authors"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we do that in the license here. These are boilerplate instructions... An example elsewhere: https://github.com/kubernetes/kubernetes/blob/master/LICENSE

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep as is for now, and key off of what we decide to do in gnatsd.

aricart
aricart reviewed Mar 20, 2018
View reviewed changes
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - only need to fix the "2015-2018 The NATS authors" bit on the license.

@ColinSullivan1 ColinSullivan1 merged commit f4a271b into master Mar 21, 2018
@ColinSullivan1 ColinSullivan1 deleted the cncf branch March 26, 2018 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aricart aricart aricart left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ColinSullivan1 @coveralls @aricart