Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort the signing keys by their public nkey during the json marshaling process to ensure the generated json array is always the same.
Since ranging over a map in golang is intentionally random, prior behavior would generate a random order for the signing key output. Arrays in json are considered ordered, so this would cause test that compare the json generated from the same
SigningKeys
to occasionally fail:["sk1","sk2"] != ["sk2","sk1"]