Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] relax protocol names to allow for ws/wss for account resolver operations #209

Merged
merged 1 commit into from
Oct 24, 2023
Merged

[FEAT] relax protocol names to allow for ws/wss for account resolver operations #209

merged 1 commit into from
Oct 24, 2023

Conversation

aricart
Copy link
Member

@aricart aricart commented Oct 24, 2023

No description provided.

@aricart aricart requested a review from jnmoyne October 24, 2023 22:13
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6633122917

  • 1 of 5 (20.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 80.911%
Changes Missing Coverage Covered Lines Changed/Added Lines %
v2/operator_claims.go 1 5 20.0%
Totals Coverage Status
Change from base Build 6224936975: -0.1%
Covered Lines: 2700
Relevant Lines: 3337
💛 - Coveralls

jnmoyne
jnmoyne approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@jnmoyne jnmoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit 012e7a3 into main Oct 24, 2023
4 of 6 checks passed
@aricart aricart deleted the operator-ws branch October 24, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnmoyne jnmoyne jnmoyne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aricart @coveralls @jnmoyne