Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] accounting for mapping weights in cluster should be handled separate #222

Merged
merged 1 commit into from
Jul 5, 2024
Merged

[FIX] accounting for mapping weights in cluster should be handled separate #222

merged 1 commit into from
Jul 5, 2024

Conversation

aricart
Copy link
Member

@aricart aricart commented Jul 4, 2024

@aricart aricart requested a review from jnmoyne July 4, 2024 17:17
@coveralls
Copy link

coveralls commented Jul 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9797993149

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 81.132%
Totals Coverage Status
Change from base Build 9020126875: 0.06%
Covered Lines: 2739
Relevant Lines: 3376
💛 - Coveralls

jnmoyne
jnmoyne approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@jnmoyne jnmoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Jul 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9798510094

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 81.12%
Totals Coverage Status
Change from base Build 9020126875: 0.05%
Covered Lines: 2737
Relevant Lines: 3374
💛 - Coveralls

@aricart aricart merged commit ff68a3b into main Jul 5, 2024
6 checks passed
@aricart aricart deleted the fix-nsc-657 branch July 5, 2024 14:31
@aricart aricart restored the fix-nsc-657 branch September 11, 2024 17:13
@aricart aricart deleted the fix-nsc-657 branch September 11, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnmoyne jnmoyne jnmoyne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NSC does not allow multiple clusters with 100% weight subject mapping
3 participants
@aricart @coveralls @jnmoyne