Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove whitespace check on subjects in JWT lib #70

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Remove whitespace check on subjects in JWT lib #70

merged 1 commit into from
Feb 12, 2020

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Feb 12, 2020

Signed-off-by: Waldemar Quevedo wally@synadia.com

@wallyqs wallyqs requested a review from aricart February 12, 2020 18:33
@wallyqs
Remove permissions validation in JWT lib
bda55e4 
Signed-off-by: Waldemar Quevedo <wally@synadia.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 336

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 88.275%
Files with Coverage Reduction New Missed Lines %
types.go 7 90.06%
Totals Coverage Status
Change from base Build 317: -0.6%
Covered Lines: 1054
Relevant Lines: 1194
💛 - Coveralls

aricart
aricart approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit 546ec07 into master Feb 12, 2020
@aricart aricart deleted the rm-spc-validation branch February 12, 2020 18:43
@wallyqs wallyqs mentioned this pull request Feb 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aricart aricart aricart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wallyqs @coveralls @aricart