Add origin option for nats websocket #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masudur Rahman <masudjuly02@gmail.com>
masudur-rahman
force-pushed
the
origin
branch
from
9735503
to
0445bf8
Compare
|
Hey @wallyqs, can you take a look at this PR ? |
wallyqs
reviewed
Sep 7, 2021
| @@ -354,6 +354,10 @@ data: | |||
| {{- else }} | |||
| no_tls: {{ .Values.websocket.noTLS }} | |||
| {{- end }} | |||
| same_origin: {{ .Values.websocket.sameOrigin }} | |||
| {{- with .Values.websocket.allowedOrigins }} | |||
| allowed_origins: ["{{ first . }}" {{- range (rest .) }}, "{{ . }}" {{- end }}] | |||
There was a problem hiding this comment.
Might be simpler to use toRawJson so that it becomes the array?
Suggested change
| allowed_origins: ["{{ first . }}" {{- range (rest .) }}, "{{ . }}" {{- end }}] | |
| allowed_origins: {{ toRawJson . }} |
There was a problem hiding this comment.
Might be simpler to use
toRawJsonso that it becomes the array?
@wallyqs, thanks for the suggestion. I've updated it. PTAL
wallyqs
approved these changes
Sep 7, 2021
Signed-off-by: Masudur Rahman <masudjuly02@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Masudur Rahman masudjuly02@gmail.com
allowed_originsis an important part for websocket.To have the options available for user, I added the
same_originandallowed_originsfield.And also if
TLSisn't enabled,no_tlsfield must be settrue. That's why I added this.