Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps #92

Merged
merged 6 commits into from
Nov 14, 2023
Merged

Update deps #92

merged 6 commits into from
Nov 14, 2023

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Nov 14, 2023 •
edited
Loading

  • Update Go client
  • Update nats-server dependency
  • Update golang.org/x/net
  • Update Kafka dependency

@wallyqs
Update Go client
8917968 
Signed-off-by: Waldemar Quevedo <wally@nats.io>
@wallyqs
Update nats-server
88ef0b4 
Signed-off-by: Waldemar Quevedo <wally@nats.io>
@wallyqs
Update golang.org/x/net
398a776 
Signed-off-by: Waldemar Quevedo <wally@nats.io>
@codecov Codecov
Copy link

codecov bot commented Nov 14, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea91c6a) 66.50% compared to head (d374a3d) 66.39%.

❗ Current head d374a3d differs from pull request most recent head d0bb168. Consider uploading reports for the commit d0bb168 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   66.50%   66.39%   -0.11%     
==========================================
  Files          28       28              
  Lines        1821     1821              
==========================================
- Hits         1211     1209       -2     
- Misses        481      482       +1     
- Partials      129      130       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wallyqs
Update Go version to 1.21
62876c3 
Signed-off-by: Waldemar Quevedo <wally@nats.io>
@wallyqs wallyqs requested a review from bruth November 14, 2023 22:02
wallyqs and others added 2 commits November 14, 2023 14:08
@wallyqs
Update kafka dependency
72befe4 
Signed-off-by: Waldemar Quevedo <wally@nats.io>
@wallyqs
Merge pull request #93 from nats-io/update-kafka
d0bb168 
Update kafka dependency
@jnmoyne jnmoyne assigned jnmoyne and unassigned jnmoyne Nov 14, 2023
@jnmoyne jnmoyne self-requested a review November 14, 2023 22:48
jnmoyne
jnmoyne approved these changes Nov 14, 2023
View reviewed changes
Copy link

@jnmoyne jnmoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs wallyqs merged commit 98e1b54 into main Nov 14, 2023
5 of 6 checks passed
@wallyqs wallyqs deleted the update-deps branch November 14, 2023 22:49
This was referenced Nov 14, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnmoyne jnmoyne jnmoyne approved these changes

@bruth bruth Awaiting requested review from bruth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wallyqs @jnmoyne