Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding user jwt payload and subscriber limits #1570

Merged
merged 2 commits into from
Aug 25, 2020
Merged

Adding user jwt payload and subscriber limits #1570

merged 2 commits into from
Aug 25, 2020

Conversation

matthiashanel
Copy link
Contributor

Addresses part of #1552

Signed-off-by: Matthias Hanel mh@synadia.com

While implementing this I noticed casts to int32, from int64 or int.
I intend to resolve this by altering jwtv2 to use int32 instead of int64.
Or would you increase the server side variables?

Addresses part of #1552

Signed-off-by: Matthias Hanel <mh@synadia.com>
server/jwt_test.go Show resolved Hide resolved
server/jwt_test.go Outdated Show resolved Hide resolved
server/jwt_test.go Show resolved Hide resolved
server/jwt_test.go Outdated Show resolved Hide resolved
server/client.go Show resolved Hide resolved
server/client.go Show resolved Hide resolved
Signed-off-by: Matthias Hanel <mh@synadia.com>
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 6d06e39 into master Aug 25, 2020
@kozlovic kozlovic deleted the limits branch August 25, 2020 15:59
@ripienaar
Copy link
Contributor

Something went wrong here, I have a super cluster with the below configuration and all works up till the nightly build for 25th, 26th nightly build I get [ERR] 172.31.0.1:45184 - cid:10 - maximum subscriptions exceeded for more or less any action I take.

port: 4222
monitor_port: 8222
server_name: $NAME

cluster {
  port: 6222

  routes = [
    nats-route://nc1:6222
    nats-route://nc2:6222
    nats-route://nc3:6222
  ]
}

gateway {
  name: $GATEWAY
  port: 7222

  gateways: [
    {
      name: "c1"
      urls: [
            "nats://nc1.c1.example.net:7222"
            "nats://nc2.c1.example.net:7222"
            "nats://nc3.c1.example.net:7222"
      ]
    }
    {
      name: "c2"
      urls: [
            "nats://nc1.c2.example.net:7222"
            "nats://nc2.c2.example.net:7222"
            "nats://nc3.c2.example.net:7222"
      ]
    }
  ]
}

accounts {
  one: {
    users = [
      {user: one, password: password}
    ]
  }

  two: {
    users = [
      {user: two, password: password}
    ]
  }

  system: {
    users = [
      {user: system, password: password}
    ]
  }
}

system_account: system

@matthiashanel
Copy link
Contributor Author

matthiashanel commented Aug 27, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants