[added] enforcement and usage of scoped signing keys #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Hanel <mh@synadia.com>
kozlovic
requested changes
Jan 14, 2021
Signed-off-by: Matthias Hanel <mh@synadia.com>
aricart
requested changes
Jan 14, 2021
Signed-off-by: Matthias Hanel <mh@synadia.com>
matthiashanel
force-pushed
the
scoped-signing-keys
branch
from
814206b
to
2cb5f1b
Compare
aricart
approved these changes
Jan 14, 2021
| continue | ||
| } | ||
| if _, ok := alteredScope[sk]; ok { | ||
| c.closeConnection(AuthenticationViolation) |
There was a problem hiding this comment.
so here we are simply d/c because their configuration changed, and a reconnect will make them have the correct permissions?
This was referenced Mar 15, 2021
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matthias Hanel mh@synadia.com
I added a lookup of the scoped signing key to applyAccountLimits.
passing in the values into the function would have made the change a lot bigger.
Currently the update strategy of scoped keys is to disconnect the clients