Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[added] support for StrictSigningKeyUsage and updated jwt library #1845

Merged
merged 3 commits into from
Jan 26, 2021

Conversation

matthiashanel
Copy link
Contributor

This will cause the server to not trust accounts/user signed by an
identity key

Signed-off-by: Matthias Hanel mh@synadia.com

To be sure I changed using len( s.trustedKeys) > 0 to a check for not nil.
To support this I moved all keys trusted into signingKeys.

This will cause the server to not trust accounts/user signed by an
identity key

Signed-off-by: Matthias Hanel <mh@synadia.com>
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if you thought about config reload and see if there is an issue (maybe existing prior to this change).

server/jwt.go Show resolved Hide resolved
The boot strapping system account will assume the account is issued by
the operator.
If this is not desirable, the system account can be provided right away
as resolver_preload.

Signed-off-by: Matthias Hanel <mh@synadia.com>
server/jwt.go Outdated Show resolved Hide resolved
server/server.go Outdated Show resolved Hide resolved
Signed-off-by: Matthias Hanel <mh@synadia.com>
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants