Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for client Subscription.Close() #182

Closed
kozlovic opened this issue Oct 21, 2016 · 0 comments · Fixed by #203
Closed

Add support for client Subscription.Close() #182

kozlovic opened this issue Oct 21, 2016 · 0 comments · Fixed by #203
Assignees
@kozlovic
Labels
customer requested enhancement

Comments

@kozlovic
Copy link
Member

kozlovic commented Oct 21, 2016 •
edited
Loading

Add support for Subscription.Close()

See https://github.com/nats-io/go-nats-streaming/issues/114
@kozlovic kozlovic self-assigned this Oct 21, 2016
@kozlovic kozlovic changed the title Add Subscription.Close() to close durables without having them unsubscribed Add support for client Subscription.Close() Oct 21, 2016
kozlovic added a commit to nats-io/stan.go that referenced this issue Oct 21, 2016
@kozlovic
[ADDED] Subscription.Close() allows closing durable
77819a9 
Resolves #114
Will require nats-io/nats-streaming-server#182
to be implemented.
@kozlovic kozlovic mentioned this issue Oct 21, 2016
Merged
kozlovic added a commit to nats-io/stan.go that referenced this issue Oct 26, 2016
@kozlovic
[ADDED] Subscription.Close() allows closing durable subscriptions
7219ce2 
Resolves #114
Will require nats-io/nats-streaming-server#182
to be implemented.
kozlovic added a commit to nats-io/stan.go that referenced this issue Nov 4, 2016
@kozlovic
[ADDED] Subscription.Close() allows closing durable subscriptions
0d48ba8 
Resolves #114
Will require nats-io/nats-streaming-server#182
to be implemented.
This was referenced Nov 14, 2016
Closed
Closed
kozlovic added a commit that referenced this issue Nov 28, 2016
@kozlovic
[ADDED] Support for Subscription.Close()
5064f8d 
Client can now close a subscription without calling Unsubscribe()
which was a problem for durable subscriptions. Clients were forced
to close the connection if they wanted to stop consuming but not
delete the subscription.

Resolves #182
kozlovic added a commit that referenced this issue Nov 28, 2016
@kozlovic
[ADDED] Support for Subscription.Close()
dcd0864 
Client can now close a subscription without calling Unsubscribe()
which was a problem for durable subscriptions. Clients were forced
to close the connection if they wanted to stop consuming but not
delete the subscription.

Resolves #182
kozlovic added a commit that referenced this issue Nov 28, 2016
@kozlovic
[ADDED] Support for Subscription.Close()
76ff263 
Client can now close a subscription without calling Unsubscribe()
which was a problem for durable subscriptions. Clients were forced
to close the connection if they wanted to stop consuming but not
delete the subscription.

Resolves #182
@kozlovic kozlovic mentioned this issue Nov 28, 2016
Merged
@ghost ghost added the waffle:needs review label Nov 28, 2016
kozlovic added a commit that referenced this issue Nov 28, 2016
@kozlovic
[ADDED] Support for Subscription.Close()
26301df 
Client can now close a subscription without calling Unsubscribe()
which was a problem for durable subscriptions. Clients were forced
to close the connection if they wanted to stop consuming but not
delete the subscription.

Resolves #182
@ghost ghost removed the waffle:needs review label Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kozlovic kozlovic

Labels
customer requested enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ADDED] Support for Subscription.Close() nats-io/nats-streaming-server
1 participant
@kozlovic