Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Possible panic on FileStore.Close() with expiration #366

Merged
merged 1 commit into from
Aug 9, 2017
Merged

[FIXED] Possible panic on FileStore.Close() with expiration #366

merged 1 commit into from
Aug 9, 2017

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented Aug 9, 2017

On store close, the files were closed before the expiration routine
was shutdown, which could cause that routine to still try to
open files that have been removed from the internal file manager.

Resolves #365

@kozlovic
[FIXED] Possible panic on FileStore.Close() with expiration
28d4412 
On store close, the files were closed before the expiration routine
was shutdown, which could cause that routine to still try to
open files that have been removed from the internal file manager.

Resolves #365
@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 94.542% when pulling 28d4412 on fix_fstore_expire_panic_on_store_close into a02c43a on master.

@kozlovic kozlovic merged commit 1010ffb into master Aug 9, 2017
@kozlovic kozlovic deleted the fix_fstore_expire_panic_on_store_close branch August 9, 2017 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FileStore could panic on Close() while expiration in progress
2 participants
@kozlovic @coveralls