Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JetStream: with "ack none" subscriptions, library should never send [N]ACKs #494

Closed
kozlovic opened this issue Dec 8, 2021 · 0 comments · Fixed by #495
Closed

JetStream: with "ack none" subscriptions, library should never send [N]ACKs #494

kozlovic opened this issue Dec 8, 2021 · 0 comments · Fixed by #495
Assignees
@kozlovic

Comments

@kozlovic
Copy link
Member

kozlovic commented Dec 8, 2021

Since the server will never redeliver nor do anything with an ACK, there is no point in the library sending ACKs to the server. The ACK calls do not need to fail, simply not send anything to the server.
@kozlovic kozlovic self-assigned this Dec 8, 2021
kozlovic added a commit that referenced this issue Dec 8, 2021
@kozlovic
[FIXED] JetStream: do not send acks for js_AckNone subscriptions
cf1bac9 
When a subscription is for a consumer with js_AckNone AckPolicy,
there is no point sending ACK messages to the server since these
would be ignored.

Resolves #494

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic kozlovic mentioned this issue Dec 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kozlovic kozlovic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIXED] JetStream: do not send acks for js_AckNone subscriptions nats-io/nats.c
1 participant
@kozlovic