[FIXED] JetStream: auto-ack callback ack handling #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a message is already ack'ed (except for natsMsg_InProgress()), the library should not attempt to ack the message when the callback returns. It is even more important if the user called natsMsg_Nak() since if the callback ack'ed the message, it would defeat the purpose of the Nak. Resolves #492 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a message is already ack'ed (except for natsMsg_InProgress()),
the library should not attempt to ack the message when the
callback returns.
It is even more important if the user called natsMsg_Nak() since
if the callback ack'ed the message, it would defeat the purpose
of the Nak.
Resolves #492
Signed-off-by: Ivan Kozlovic ivan@synadia.com