[FIXED] JetStream: stream and/or consumer name checks #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aricart @derekcollison Please wait for the review. I will minimize the changes (can have a special function for non durables), but most importantly, I think that there are other APIs that accept a consumer name that should check on the name (like delete). Will ping when PR has been updated and is ready for review. |
Some of the APIs were not properly checking for missing/invalid stream and/or consumer names (presence of ".") which could lead to API calls timing out because the server had no subscription interest on the formed subject. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
kozlovic
force-pushed
the
fix_js_consumer_info_bad_name
branch
from
5e891b5
to
76d54b5
Compare
kozlovic
changed the title
|
@aricart @derekcollison Ok, PR has been updated and is now ready for review. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the APIs were not properly checking for missing/invalid
stream and/or consumer names (presence of ".") which could lead
to API calls timing out because the server had no subscription
interest on the formed subject.
Signed-off-by: Ivan Kozlovic ivan@synadia.com