natsConnection_Buffered: fix returned value in case of error

[kolomenkin]

This function returns number of bytes in the buffer.
It is incorrect to return value from natsStatus enum.

We could keep setting internal error code.
But in this case we should set error code for other cases too where we return -1

[kozlovic]

@kolomenkin Thank you fro your contribution. It looks like you based your fix from the dev branch but posted against main branch. If you could update/re-create your PR from the main branch instead - since this is a fix and should go in the main branch, that would be great!

[kolomenkin]

@kozlovic , sorry, my mistake. I knew I should create PR against dev, but forgot to ensure this.
I updated PR's target branch few moments ago.

[kozlovic]

@kolomenkin But actually no, the way we are doing it (maybe wrong, but that's our procedure), is that a fix should go against main branch, so that it will be available for any "patch" release if one is needed. However, when adding a new feature, or breaking changes, then it should be submitted against dev so that it goes only in the next major/minor release.

I would qualify your change as a fix, so it should be done against main. Thank you for your understanding!

[kozlovic]

At this point, from your fork, make sure that you are up-to-date with the upstream main branch and create a PR with that one line change. There should not be 7 commits like there is in this PR.

[kolomenkin]

@kozlovic , sorry, my first PR fix was incorrect.
Now I rebased my commit and branch on top of latest master branch.
So now there is only 1 commit in PR.

[kozlovic]

LGTM. Thank you for your contribution!