Fixed download of NATS Server for latest/main #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "latest" was not working and would always use the one from nats.c.deps. As for "main", I noticed lately that sometimes, we would get a binary of size 0, which would make all tests using the nats-server to fail. So make sure that we can run the server and get a valid version string. If not, repeat the test up to 5 times, otherwise fail the run. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
|
@levb If you get a chance tomorrow (01/16/2024), could you review this one? Without this, the run that uses |
levb
reviewed
Jan 16, 2024
| @@ -11,6 +11,7 @@ echo "build opts = " $3 | |||
| echo "test opts = " $4 | |||
|
|
|||
| if [ "$NATS_TEST_SERVER_VERSION" != "" ]; then | |||
| rm -fr $HOME/nats-server* | |||
levb
reviewed
Jan 16, 2024
| @@ -19,14 +20,33 @@ if [ "$NATS_TEST_SERVER_VERSION" != "" ]; then | |||
|
|
|||
| if [ "$rel" != "${rel#v}" ] && wget https://github.com/nats-io/nats-server/releases/download/$rel/nats-server-$rel-linux-amd64.tar.gz; then | |||
| tar -xzf nats-server-$rel-linux-amd64.tar.gz | |||
| mv nats-server-$rel-linux-amd64 $HOME/nats-server-$rel | |||
| mv nats-server-$rel-linux-amd64 nats-server | |||
There was a problem hiding this comment.
@wallyqs should the retry logic be added to your script?
levb
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "latest" was not working and would always use the one from nats.c.deps.
As for "main", I noticed lately that sometimes, we would get a binary of size 0, which would make all tests using the nats-server to fail. So make sure that we can run the server and get a valid version string. If not, repeat the test up to 5 times, otherwise fail the run.
Signed-off-by: Ivan Kozlovic ivan@synadia.com