[ADDED] js_PauseConsumer support (also changed jsConsumerConfig, jsCo… #726
Conversation
| @@ -63,6 +63,7 @@ jobs: | |||
| packages: | |||
| - g++-9 | |||
| env: | |||
| - NATS_TEST_SERVER_VERSION=main | |||
There was a problem hiding this comment.
Originally, the nats.c.deps contained the executable of the latest release and this is what we would be using. When in dev cycle, I would occasionally update the servers in nats.c.deps to a version that I needed for testing (say in this case here the server version that would contain the pause consumer feature).
Since it looks like we don't really need the nats.c.deps (at least for the NATS Server, we still need for the streaming server and the pbuf library), and since you have a matrix run for the latest server release already, maybe you could change the buildOnTravis.sh script to use main if NATS_TEST_SERVER_VERSION env variable is not set? So you would not have to add it here?
There was a problem hiding this comment.
Yes, I was thinking about doing that, and maybe testing with a few older server releases too. Separate PR? Here, I just wanted to make sure that my new tests are running with checks in CI.
…nsumerInfo)
Fixes #717