Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KV get revision #301

Closed
aricart opened this issue May 16, 2022 · 0 comments · Fixed by #302
Closed

KV get revision #301

aricart opened this issue May 16, 2022 · 0 comments · Fixed by #302

Comments

@aricart
Copy link
Member

aricart commented May 16, 2022

nats-io/nats-architecture-and-design#93
aricart added a commit that referenced this issue May 16, 2022
@aricart
[FEAT] implements the ability in KV to request a specific revision fo…
4af5a1b 
…r a key

FIX #301
@aricart aricart mentioned this issue May 16, 2022
Merged
aricart added a commit that referenced this issue May 17, 2022
@aricart
[FEAT] implements the ability in KV to request a specific revision fo…
3a48162 
…r a key (#302)

- [FEAT] implements the ability in KV to request a specific revision for a key

- [FEAT] added check when retrieving a key and specifying a sequence (new feature), that the key matched. If not, null is returned as the sequence is not referencing the expected key.

- [FIX] conversion from stored message captured the key as provided by the client, and returned an entry with the said key. This issue is only a problem when combined with the new feature to specify a revision for the key, as the entry returned could have been not related to the key.

FIX #301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FEAT] implements the ability in KV to request a specific revision for a key nats-io/nats.deno
1 participant
@aricart