-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] added ability to opt-out from mime formatted header names #145
Conversation
…serialized in a canonical form. [change] `Status` and `Description` header entries are removed. These values are accessible from `status`, `code`, and `description` [change] accessing values, will return a list of all the values stored under all headers that have the same case-insensitive name. [change] to access specific keys in a case-sensitive way, iterate over the header values.
Implemented as specified here: #147 |
nats.deno is going to implement it as described in #147.
No key normalization, headers are insensitive, if the user wants to store a canonical header, they can use the provided function to transform the key. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…`delete`. If true, case sensitive operations are performed.
All options with the exception of
This should honor what the user wants while providing a mechanism to further clamp for more constrained requirements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor comment about performing canonicalMIMEHeaderKey() twice on a set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…on-sensical will be predictable.
@kozlovic raised the point that append what preserving the input's case, but options provided could be in disagreement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
added an optional argument that allows an application's use of headers to opt-out of mime header formatting. To retrieve values, they must also opt-out