infra to build js-cluster for tests #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovic
reviewed
Apr 24, 2021
tests/helpers/cluster.ts
Outdated
| cluster.forEach((s) => { | ||
| console.log( | ||
| `launched server [${s.process.pid}] at ${s.hostname}:${s.port} - monitor ${s.monitoring}`, | ||
| `nats-server -c ${s.configFile} [${s.process.pid}] at nats://${s.hostname}:${s.port} cluster://${s.hostname}:${s.cluster} http://127.0.0.1:${s.monitoring}`, |
There was a problem hiding this comment.
With JS, for clustering to work well, the routes need to be explicit because the replicas and quorum size is based on that. Meaning that a server should have
cluster {
port: xxx
routes [
"nats://thisserver:routeport",
"nats://2ndserver:routeport",
"nats://3rdserver:routeport",
]
}
So I am not sure if having a server just with cluster port running is enough.
There was a problem hiding this comment.
They are:
All the cluster ports are captured here:
And then after all captured, self-routes are removed (I know they don't have to be)
And finally, all the servers are restarted with their JS cluster configurations.
There was a problem hiding this comment.
A full config looks like this:
port: 4222
cluster {
name: MOYI2Y0O2HYD057TSX017D
listen: "127.0.0.1:49922"
routes [
nats://127.0.0.1:49928
]
}
ports_file_dir: /var/folders/1y/_rk6yz81341g5q8k1vr5nqmw0000gq/T
host: "127.0.0.1"
http: "127.0.0.1:49921"
jetstream {
max_file_store: 1048576
max_memory_store: 1048576
store_dir: /tmp/jetstream/MOYI2Y0O2HYD057TSX01ED
}
server_name: MOYI2Y0O2HYD057TSX01AV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.