Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conn.closed() resolved error not always the actual reason for the error #294

Merged
merged 1 commit into from
May 12, 2022

Conversation

aricart
Copy link
Member

@aricart aricart commented May 12, 2022

[FIX] while runtime authorization errors are notified, errors related to connection lastError were not properly reported by the closed() promise - this typically resulted in a "Connection Refused" rather than the actual reason.

FIX #268

… to connection lastError were not properly reported by the closed() promise - this typically resulted in a "Connection Refused" rather than the actual reason.

FIX #268
@aricart aricart requested a review from kozlovic May 12, 2022 20:30
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit 9fbbb89 into main May 12, 2022
@aricart aricart deleted the runtime-error-notified branch May 12, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authentication failures sometimes result in ConnectionRefused exceptions instead
2 participants