Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] multiple consumer filters #469

Merged
merged 4 commits into from
Jan 19, 2023
Merged

[FEAT] multiple consumer filters #469

merged 4 commits into from
Jan 19, 2023

Conversation

aricart
Copy link
Member

@aricart aricart commented Jan 19, 2023

[FEAT] consumer filter_subjects support - this feature is exclusive of the filter_subject but allows a consumer to filter multiple subjects in a stream. To set, specify filter_subjects instead of filter_subject or if using consumer options builder filterSubject() can be called multiple times.

[CHANGE] filter_subject (and filter_subjects) can be updated, the server removed this restriction

…f the filter_subject but allows a consumer to filter multiple subjects in a stream. To set, specify filter_subjects instead of filter_subject or if using consumer options builder filterSubject() can be called multiple times.

[CHANGE] filter_subject (and filter_subjects) can be updated, the server removed this restriction
@aricart aricart requested a review from Jarema January 19, 2023 21:11
@aricart aricart changed the base branch from main to dev January 19, 2023 21:11
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…f the filter_subject but allows a consumer to filter multiple subjects in a stream. To set, specify filter_subjects instead of filter_subject or if using consumer options builder filterSubject() can be called multiple times.

[CHANGE] filter_subject (and filter_subjects) can be updated, the server removed this restriction
@aricart aricart temporarily deployed to CI January 19, 2023 21:23 — with GitHub Actions Inactive
@aricart aricart merged commit e5bea9a into dev Jan 19, 2023
@aricart aricart deleted the multiple-consumer-filters2 branch January 19, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants