Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull consumer - consumer deleted notifications #495

Merged
merged 2 commits into from
Mar 20, 2023
Merged

pull consumer - consumer deleted notifications #495

merged 2 commits into from
Mar 20, 2023

Conversation

aricart
Copy link
Member

@aricart aricart commented Mar 16, 2023

added ability for client to see on pull consumers to handle consumer deleted.

@aricart aricart changed the base branch from main to dev March 16, 2023 00:09
…erpreted as a terminal error - this enables the client to detect this on pull consumers - note that for push consumers the consumer deleted error is not raised, so heartbeats are the oly reliable mechanism to detect when things go wrong.
@aricart aricart changed the title Pull silence pull consumer - consumer deleted notifications Mar 20, 2023
@aricart aricart marked this pull request as ready for review March 20, 2023 18:52
@aricart aricart requested a review from Jarema March 20, 2023 18:52
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit 8d7ec8b into dev Mar 20, 2023
@aricart aricart deleted the pull-silence branch March 20, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants