Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to service info and stats #523

Merged
merged 2 commits into from
May 31, 2023
Merged

Changes to service info and stats #523

merged 2 commits into from
May 31, 2023

Conversation

aricart
Copy link
Member

@aricart aricart commented May 30, 2023

[CHANGE] [SRV] [BREAKING] info operation now returns endpoints instead of subjects. Endpoints contain not only the subject for each of the endpoints but also the associated endpoint metadata

[CHANGE] [SRV] [BREAKING] removed NamedEndpointStats#metadata reference; use EndpointInfo#metadata instead

…ead of `subjects`. Endpoints contains not only the subject for each of the endpoints but also the associated endpoint metadata
@aricart aricart requested a review from piotrpio May 31, 2023 12:51
@piotrpio
Copy link
Contributor

Besides adding more verbose EndpointInfo instead of array of subjects, we also agreed to remove endpoint metadata from STATS response.

…ence, reference `EndpointInfo#metadata` instead
@aricart aricart temporarily deployed to CI May 31, 2023 13:26 — with GitHub Actions Inactive
Copy link
Contributor

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart changed the title [CHANGE] [SRV] [BREAKING] info operation now returns endpoints instead of subjects. Changes to service info and stats May 31, 2023
@aricart aricart merged commit ace0fec into dev May 31, 2023
@aricart aricart deleted the srv-info-changes branch May 31, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants