[DENO] optimization on write to just queue up #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspervonb
reviewed
Jun 8, 2023
src/deno_transport.ts
Outdated
| } | ||
| this.pendingWrite = writeAll(this.conn, frame).then(() => { | ||
| this.pendingWrite = null; | ||
| queueMicrotask(() => { |
There was a problem hiding this comment.
This didn't have an observable effect so unsure if we should be keeping it. Was trying it to see if the stack would empty which it did not seem to. Promises effectively schedules a micro task.
Suggested change
| queueMicrotask(() => { | |
| queueMicrotask(() => { |
caspervonb
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Benched a bit, definitively faster than main (this is on deno 1.33.x as 1.4 has major issues).
Repositories/nats.deno (on branch 'main') $ deno run --reload -A examples/bench.js --subject a --pub --payload 3500 --count 1000000 --pendingLimit 1024
pub 96,089 msgs/sec - [10.41 secs] ~ 320.73 MB/sec 10407/10407
Repositories/nats.deno (on branch 'write-perf') $ deno run --reload -A examples/bench.js --subject a --pub --payload 3500 --count 1000000 --pendingLimit 1024
pub 421,322 msgs/sec - [2.37 secs] ~ 1.37 GB/sec 2373.4810420000003/2373.4810420000003
caspervonb
reviewed
Jun 9, 2023
src/deno_transport.ts
Outdated
| await this.enqueue(TE.encode("")); | ||
| this.frames.push(Empty); | ||
| const d = deferred<void>(); | ||
| this.maybeWriteFrame(d); |
There was a problem hiding this comment.
Could just await this.pendingWrite here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@caspervonb this is effectively your simplification, including the changes to support
debugand the closing promise.