jetstream also support jsm options #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonberrutti
force-pushed
the
extend-jetstream-options
branch
from
fbe43d8
to
b6b41c8
Compare
aricart
requested changes
Mar 22, 2024
| @@ -505,7 +505,7 @@ export class NatsConnectionImpl implements NatsConnection { | |||
| } | |||
|
|
|||
| jetstream( | |||
| opts: JetStreamOptions = {}, | |||
| opts: JetStreamOptions | JetStreamManagerImpl = {}, | |||
There was a problem hiding this comment.
this doesn't look right - JetstreamManagerImpl?
There was a problem hiding this comment.
you are right
| @@ -651,7 +651,7 @@ export interface NatsConnection { | |||
| * | |||
| * @param opts | |||
| */ | |||
| jetstream(opts?: JetStreamOptions): JetStreamClient; | |||
| jetstream(opts?: JetStreamOptions | JetStreamManagerOptions): JetStreamClient; | |||
There was a problem hiding this comment.
Should this be JetStreamOptions & JetstreamManagerOptions - this would allow all options be be specified.
There was a problem hiding this comment.
Doh - the current type for JetStreamManagerOptions extends JetStreamOptions, so this is a good change.
|
@ramonberrutti thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend jetstream options with jetstreamManager options