Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub (with support for queue groups) #25

Merged
merged 5 commits into from
Mar 28, 2017
Merged

Sub (with support for queue groups) #25

merged 5 commits into from
Mar 28, 2017

Conversation

mmmries
Copy link
Collaborator

@mmmries mmmries commented Mar 28, 2017

Adds SUB formatting in the Gnat.Command module including support for queue_group. I also added documentation for subscribing and a test to make sure that we fanout messages in some cases and partition messages when queue group is provided.

/cc @newellista @film42 @tallguy-hackett

@mmmries
Copy link
Collaborator Author

mmmries commented Mar 28, 2017

Fixes #11

lib/gnat.ex Outdated

By default each subscriber will receive a copy of messages on the topic.
When a queue_group is supplied messages will be spread amongs the subscribers
int the same group. (see [nats queueing](https://nats.io/documentation/concepts/nats-queueing/))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the int the same should be in the same... no ints here ;)

@mmmries mmmries mentioned this pull request Mar 28, 2017
@newellista
Copy link
Collaborator

:shipit:

@mmmries mmmries merged commit b326a79 into master Mar 28, 2017
@mmmries mmmries deleted the sub branch March 28, 2017 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants