Partial parse #26
Merged
Partial parse #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rough cut at #5
I stole the basic idea here from @newellista who suggested that we only really need to keep the unmatched bytes around for the parser state (no need to have a
state: :waitingetc). This ends up introducing a few more conditionals which always degrades the readability a bit.Before I try to refactor I first wanted to get some feedback on whether this looked like a reasonable attempt at parsing.
Benchmarks before and after the change show no significant change in performance (~
81kparses/sec)./cc @newellista @tallguy-hackett