Subscribe("foo", nil) inconsistency between Conn and EncodedConn

[rbucker]

EncodedConn.Subscribe("foo", nil) throws a nil pointer exception instead of deleting the subscription as documented in the README.

Conn.Subscribe("foo", nil) returns normally but does not delete the subscription.

Since there is a Subscription.Unsubscribe() then this 'nil' behavior should be avoided and either return an error in the error field or throw an exception. Looking into the Subscribe code there is some code that looks for a nil callback and some that throws an exception when reflecting.

[derekcollison]

This in the README correct?

[derekcollison]

Send a PR.. ;)

[derekcollison]

Will take a look when I have some time.. Thanks..

[rbucker]

I found this comment in the code:
If no MsgHandler is given, the subscription is a synchronous subscription and can be polled via Subscription.NextMsg().

[derekcollison]

A normal connection with no handler creates a synchronous subscriber, however will look at the EncodedConn version more closely..

[derekcollison]

EncodedConn is not built currently for NextMsg, I will add an err return though.