Make MaxChanLen a per Conn option #42
Closed
+10
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still failed, but could be transient. |
|
Yeah.. the failures are to do with reconnects which I didn't touch at all. The |
|
Can't figure out how to make Travis rebuild without pushing more code :/ |
|
I re-ran the tests with the same failures, and without your changes they pass, so something is impacting them. |
|
I fixed this separately.. |
|
Whoops, I forgot about this PR. Works for me, thanks! |
TheGhoul21
pushed a commit
to TheGhoul21/nats.go
that referenced
this pull request
Jun 20, 2024
…ptions Change Arc to Box for callbacks, remove Clone impl on ConnectionOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our particular use case uses many low throughput subscriptions. The default channel length of 64k uses quite a lot of memory and isn't necessary for us.
This PR adds the ability to override
MaxChanLen