Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace megacheck with staticcheck #425

Merged
merged 2 commits into from
Jan 9, 2019
Merged

Replace megacheck with staticcheck #425

merged 2 commits into from
Jan 9, 2019

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented Jan 9, 2019

Megacheck has been deprecated.
Dropping Go 1.9 from build matrix since staticcheck does not work
with that and Go 1.9 is technically no longer supported.

Signed-off-by: Ivan Kozlovic ivan@synadia.com

Megacheck has been deprecated.
Dropping Go 1.9 from build matrix since staticcheck does not work
with that and Go 1.9 is technically no longer supported.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Ensure that we get a stable value when getting the base for
number of go routines.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 189cbde into master Jan 9, 2019
@kozlovic kozlovic deleted the replace_megacheck branch January 9, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants