PubSub from same connection performance improvement #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate. Signed-off-by: Derek Collison <derek@nats.io>
kozlovic
requested changes
Nov 12, 2019
There was a problem hiding this comment.
Either we remove the test or need to update travis.yml to have this test actually executed. Also, I still don't know what to think of adding deps that are only for tests, which results in projects that then pull each other (server->client, client->server: circular deps).
kozlovic
requested changes
Nov 12, 2019
Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
force-pushed
the
pubsub
branch
from
1274629
to
d6913a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PubSub from same connection was contending on lock checking closed state.
Signed-off-by: Derek Collison derek@nats.io