Remove unused code from readMIMEHeader #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The strs slice is not used - it seems to have stuck around from net/textproto.ReadMIMEHeader. Signed-off-by: Rutger Broekhoff <rutger@viasalix.nl>
variadico
approved these changes
Jun 28, 2021
There was a problem hiding this comment.
Ah, ok. strs never gets initialized or modified so its length is always zero. And because it's always zero, we don't need that if statement.
Looks like in the original code there was a possibility of strs being initialized, but our code is a bit different and doesn't include that case.
LGTM! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
strsslice is not used - it seems to have stuck around fromnet/textproto.ReadMIMEHeader.