Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPDATED] JetStream go doc in the interface #818

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented Sep 9, 2021

Copied the go doc from implementation to interface, and reworded
some sections.

I decided to copy versus move because some IDE (for instance VS code)
seem to show the doc (when hovering) from the implementation, not
the interface.

Signed-off-by: Ivan Kozlovic ivan@synadia.com

Copied the go doc from implementation to interface, and reworded
some sections.

I decided to copy versus move because some IDE (for instance VS code)
seem to show the doc (when hovering) from the implementation, not
the interface.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 87.302% when pulling 8ec6f2c on copy_sub_go_doc_to_interface into 42edba4 on main.

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit eb89c8a into main Sep 9, 2021
@kozlovic kozlovic deleted the copy_sub_go_doc_to_interface branch September 9, 2021 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants