Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tune kv subscribe supported functions keys / history / purge #631

Merged
merged 4 commits into from
Apr 5, 2022
Merged

Conversation

scottf
Copy link
Contributor

@scottf scottf commented Mar 31, 2022

  1. saves an entire round trip to the server b/c of getConsumerInfo.
  2. refactor added getCalculatedPending since needed in more than 1 place
  3. better design of visitSubject which is used for methods keys / history / purge

Copy link
Contributor Author

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saves an entire round trip to the server b/c of getConsumerInfo. Plus the getCalculatedPending is needed in more than 1 place

@scottf scottf changed the title tune kv watch and subscribe supported functions keys / history / purge tune kv subscribe supported functions keys / history / purge Apr 1, 2022
@scottf scottf merged commit b551637 into main Apr 5, 2022
@scottf scottf deleted the tune-kv branch April 5, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant