Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service subject in responses must contain group path #834

Merged
merged 1 commit into from
Jan 24, 2023
Merged

service subject in responses must contain group path #834

merged 1 commit into from
Jan 24, 2023

Conversation

scottf
Copy link
Contributor

@scottf scottf commented Jan 24, 2023

No description provided.

@arondi arondi self-requested a review January 24, 2023 21:55
arondi
arondi approved these changes Jan 24, 2023
View reviewed changes
Copy link
Collaborator

@arondi arondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nitpick change EndpointResponse variable name in tests es to er

@scottf scottf merged commit fd2df06 into main Jan 24, 2023
@scottf scottf deleted the service-proper-response-subjects branch January 24, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arondi arondi arondi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottf @arondi