[Fix #325] Removes the server address from reconnection logs in examples. #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n examples. A couple of examples tries to log the server address during reconnection, through an inner reconnection callback passed as parameter to the client object. However, this kind of callback need to be defined before we instantiate the client, so the inner callback isn't able to see and access the client/connection object. The issue was originaly described into the issue nats-io#325, however a couple of other examples also implement the same logic that surely fails in the same way (not tested on my side). I only focused my tests on the example given in the original issue.
wallyqs
approved these changes
Sep 2, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of examples tries to log the server address during reconnection, through an inner reconnection callback passed as parameter to the client object.
However, this kind of callback need to be defined before we instantiate the client, so the inner callback isn't able to see and access the client/connection object.
The issue was originaly described into the issue #325, however a couple of other examples also implement the same logic that surely fails in the same way (not tested on my side). I only focused my tests on the example given in the original issue.