Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes incorrect formatting in .travis.yml. #420

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

WillCodeCo
Copy link
Contributor

The intention seems to be for Travis to allow the following build jobs to fail, without causing the whole build operation to break:

  • where python="3.8"
  • where python="3.9"
  • where name="Python: 3.9/uvloop"

However the YAML file is incorrectly formatted to communicate this, meaning that builds are failing. This commit addresses this.

The intention seems to be for Travis to allow the following build jobs to fail, without causing the whole build operation to fail:
- where `python="3.8"`
- where `python="3.9"`
- where `name="Python: 3.9/uvloop"`

However the YAML file is incorrectly formatted to communicate this, meaning that builds are failing. This commit addresses this.
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@wallyqs wallyqs merged commit 0b5bfd6 into nats-io:main Feb 15, 2023
@WillCodeCo WillCodeCo deleted the fix-travis-allow-failures branch February 16, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants