Take impl AsRef<Path> instead of PathBuf in credentials APIs
#1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolobarbolini
force-pushed
the
nicer-path-api
branch
from
795e6c8
to
80367e1
Compare
caspervonb
approved these changes
Jul 17, 2023
Actually it is |
|
Was hoping there was an |
|
I will merge it after the 0.30.1 patch release. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this is documented anywhere but this is the style used by all APIs that deal with the filesystem. Sometimes it even gets used when a
PathBufwould have been the better choice when it comes to heap allocations, because it's nicer to use.The reason why this is the preferred method is that a bunch of things implement
AsRef<Path>, including&str, so it avoids the manual cast to&Pathor memcpy toPathBuf.