Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change stream::Config::duplicate_window to Duration #1023

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Change stream::Config::duplicate_window to Duration #1023

merged 1 commit into from
Jul 12, 2023

Conversation

n1ghtmare
Copy link
Collaborator

Closes #1001

@n1ghtmare n1ghtmare self-assigned this Jul 11, 2023
Jarema
Jarema approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jarema Jarema merged commit 368a13a into nats-io:main Jul 12, 2023
@Jarema Jarema mentioned this pull request Jul 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarema Jarema Jarema approved these changes

@caspervonb caspervonb Awaiting requested review from caspervonb

Assignees

@n1ghtmare n1ghtmare

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stream::Config duplicate_window should be a Duration
2 participants
@n1ghtmare @Jarema