Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up ServerOp parsing #1052

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Tidy up ServerOp parsing #1052

merged 1 commit into from
Jul 25, 2023

Conversation

paolobarbolini
Copy link
Contributor

Cleans up ServerOp parsing by reducing panicking branches, allocations plus other improvements.

@caspervonb caspervonb self-requested a review July 24, 2023 11:33
caspervonb
caspervonb reviewed Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary lgtm, at the lower end of the merge queue tho.

Jarema
Jarema approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jarema Jarema merged commit f913c83 into nats-io:main Jul 25, 2023
13 checks passed
@Jarema Jarema mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caspervonb caspervonb caspervonb approved these changes

@Jarema Jarema Jarema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paolobarbolini @caspervonb @Jarema