Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FromStr for jetstream::kv::Operation #1056

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

n1ghtmare
Copy link
Collaborator

Tidy up the KV operations a bit.

Further refactor of KV operations
@n1ghtmare n1ghtmare self-assigned this Jul 26, 2023
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, one nit as I realized this is a public type.

Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@caspervonb caspervonb changed the title Refactor KV operations Implement FromStr for Operation Jul 26, 2023
@caspervonb caspervonb changed the title Implement FromStr for Operation Implement FromStr for jetstream::kv::Operation Jul 26, 2023
@caspervonb caspervonb merged commit 47a4790 into nats-io:main Jul 26, 2023
13 checks passed
@Jarema Jarema mentioned this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants